test: skip test-cluster-dgram-reuse on AIX 7.3#62238
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 17, 2026
Merged
test: skip test-cluster-dgram-reuse on AIX 7.3#62238nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
sxa
changed the title
Member
Author
|
(Force push to fix typo in commit message) |
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/23052607472 |
Collaborator
Collaborator
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Member
Author
|
(Second force push in the absence of this having been reviewed to apply linter fixes) |
Collaborator
Contributor
|
Do you mean to keep this as a draft or is it ready for reviews? |
Collaborator
Member
Author
Yeah it's ready now - I had been just holding off until it passed the linters. |
richardlau
approved these changes
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62238 +/- ##
=======================================
Coverage 89.67% 89.68%
=======================================
Files 676 676
Lines 206469 206555 +86
Branches 39537 39553 +16
=======================================
+ Hits 185157 185249 +92
+ Misses 13448 13435 -13
- Partials 7864 7871 +7 🚀 New features to boost your workflow:
|
richardlau
added
the
author ready
addaleax
approved these changes
Mar 17, 2026
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 06a8240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified during AIX 7.3 testing being done under #61660
TL;DR This is a workaround for a hang which is showing up when node is built on or AIX 7.3 machines. If the binary is built on 7.2 and then run on 7.3 (which would be true for anyone using our release builds) then it seems to work ok. It is a consistently reproducible failure.
While this version check technically stops an AIX 7.2 binary being tested on 7.3 it is an appropriate change to allow AIX 7.3 to be included in the CI without impacting the coverage we have on 7.2.
Alternate solutions:
commonand use it there (Suggestions on variable names etc. welcome if we go for this, but I don't think there's too much precedent)